-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] make sure nodiscard Status can work in non-test mode #33167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverbullet233
changed the title
[Enhancement] make sure nodiscard status can work
[Enhancement] make sure nodiscard Status can work in non-test mode
Oct 19, 2023
stdpain
reviewed
Oct 19, 2023
stdpain
reviewed
Oct 19, 2023
silverbullet233
force-pushed
the
fix_status
branch
from
October 20, 2023 05:30
864d90d
to
5100153
Compare
silverbullet233
force-pushed
the
fix_status
branch
from
October 25, 2023 05:46
6bef62f
to
a8f2878
Compare
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
fix_status
branch
from
October 26, 2023 01:59
b15d8fc
to
a4c0490
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 16 / 98 (16.33%) file detail
|
satanson
approved these changes
Oct 26, 2023
kangkaisen
approved these changes
Oct 26, 2023
24 tasks
stephen-shelby
pushed a commit
that referenced
this pull request
Oct 12, 2024
Signed-off-by: Smith Cruise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix remaining compilation issues and add nodiscard keyword to Status in non-test mode.
be ut has too many compilation issues to fix, and we will deal with them later.
TODO:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: