Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] make sure nodiscard Status can work in non-test mode #33167

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Oct 19, 2023

Fix remaining compilation issues and add nodiscard keyword to Status in non-test mode.

be ut has too many compilation issues to fix, and we will deal with them later.

TODO:

  • fix compilation issues in unit test
  • remove all nodiscard keyword in all function definitions since we have added it before Status

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 changed the title [Enhancement] make sure nodiscard status can work [Enhancement] make sure nodiscard Status can work in non-test mode Oct 19, 2023
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
@github-actions
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions
Copy link

[BE Incremental Coverage Report]

fail : 16 / 98 (16.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/runtime/plan_fragment_executor.cpp 0 4 00.00% [144, 286, 477, 479]
🔵 src/exec/table_function_node.cpp 0 1 00.00% [228]
🔵 src/runtime/export_sink.cpp 0 1 00.00% [177]
🔵 src/exec/pipeline/nljoin/spillable_nljoin_build_operator.cpp 0 1 00.00% [65]
🔵 src/runtime/data_stream_sender.cpp 0 1 00.00% [624]
🔵 src/exec/spill/spill_components.h 0 1 00.00% [176]
🔵 src/storage/memtable.cpp 0 1 00.00% [181]
🔵 src/exec/pipeline/sink/file_sink_operator.cpp 0 1 00.00% [110]
🔵 src/exec/spill/input_stream.cpp 0 3 00.00% [68, 69, 70]
🔵 src/exec/pipeline/sort/local_parallel_merge_sort_source_operator.cpp 0 1 00.00% [89]
🔵 src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp 0 2 00.00% [226, 231]
🔵 src/udf/java/java_native_method.cpp 0 4 00.00% [88, 89, 90, 91]
🔵 src/exec/pipeline/nljoin/nljoin_build_operator.cpp 0 1 00.00% [53]
🔵 src/exec/hash_join_node.cpp 0 1 00.00% [259]
🔵 src/exec/pipeline/sink/table_function_table_sink_operator.cpp 0 2 00.00% [86, 124]
🔵 src/udf/java/java_data_converter.cpp 0 1 00.00% [293]
🔵 src/exec/schema_scan_node.cpp 0 1 00.00% [279]
🔵 src/exec/pipeline/sink/iceberg_table_sink_operator.cpp 0 3 00.00% [34, 70, 315]
🔵 src/exec/spill/spiller.hpp 0 3 00.00% [205, 206, 247]
🔵 src/exprs/function_call_expr.cpp 0 2 00.00% [113, 116]
🔵 src/exec/pipeline/exchange/multi_cast_local_exchange.cpp 0 1 00.00% [209]
🔵 src/udf/java/java_udf.cpp 0 2 00.00% [447, 462]
🔵 src/exec/pipeline/hashjoin/hash_join_probe_operator.cpp 0 1 00.00% [119]
🔵 src/runtime/profile_report_worker.cpp 0 2 00.00% [36, 58]
🔵 src/exec/exec_node.cpp 0 1 00.00% [324]
🔵 src/exec/pipeline/aggregate/aggregate_distinct_blocking_sink_operator.cpp 0 1 00.00% [72]
🔵 src/exec/pipeline/sink/hive_table_sink_operator.cpp 0 6 00.00% [35, 67, 104, 106, 131, 133]
🔵 src/exec/tablet_scanner.cpp 0 2 00.00% [113, 115]
🔵 src/runtime/runtime_state.cpp 0 1 00.00% [330]
🔵 src/exec/spill/spill_components.cpp 0 5 00.00% [155, 530, 531, 582, 588]
🔵 src/runtime/result_sink.cpp 0 1 00.00% [159]
🔵 src/storage/rowset_update_state.cpp 0 2 00.00% [425, 686]
🔵 src/exec/pipeline/result_sink_operator.cpp 0 1 00.00% [83]
🔵 src/runtime/file_result_writer.cpp 0 1 00.00% [58]
🔵 src/exec/topn_node.cpp 0 1 00.00% [191]
🔵 src/storage/tablet_meta_manager.cpp 0 1 00.00% [1466]
🔵 src/exprs/java_function_call_expr.cpp 0 3 00.00% [111, 123, 258]
🔵 src/storage/tablet_meta.cpp 0 1 00.00% [185]
🔵 src/exec/analytor.cpp 0 2 00.00% [366, 368]
🔵 src/runtime/runtime_filter_worker.cpp 0 3 00.00% [574, 593, 597]
🔵 src/formats/parquet/group_reader.cpp 1 4 25.00% [96, 677, 685]
🔵 src/storage/tablet_updates.cpp 1 2 50.00% [4449]
🔵 src/exec/aggregator.cpp 1 2 50.00% [615]
🔵 src/storage/binlog_builder.cpp 1 2 50.00% [76]
🔵 src/storage/persistent_index.cpp 2 4 50.00% [3285, 4769]
🔵 src/exec/sorting/merge_cascade.cpp 1 2 50.00% [91]
🔵 src/exec/olap_scan_prepare.cpp 2 2 100.00% []
🔵 src/exec/pipeline/scan/connector_scan_operator.cpp 1 1 100.00% []
🔵 src/io/cache_input_stream.cpp 1 1 100.00% []
🔵 src/runtime/buffer_control_block.cpp 1 1 100.00% []
🔵 src/exec/stream/scan/stream_scan_operator.h 1 1 100.00% []
🔵 src/storage/lake/update_manager.cpp 1 1 100.00% []
🔵 src/runtime/chunk_cursor.cpp 1 1 100.00% []
🔵 src/exec/pipeline/table_function_operator.cpp 1 1 100.00% []

@kangkaisen kangkaisen merged commit b9f0bf7 into StarRocks:main Oct 26, 2023
38 of 39 checks passed
stephen-shelby pushed a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants