Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] remove some unused code #16512

Merged
merged 4 commits into from
Jan 11, 2023
Merged

[Refactor] remove some unused code #16512

merged 4 commits into from
Jan 11, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Jan 11, 2023

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Remove some unused code prepared for open implicit type cast default.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

chaoyli
chaoyli previously approved these changes Jan 11, 2023
View reviewed changes
@trueeyu
Copy link
Contributor Author

trueeyu commented Jan 11, 2023

run starrocks_clang-format

github-actions[bot]
github-actions bot reviewed Jan 11, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/runtime/free_list.hpp Show resolved Hide resolved
be/src/runtime/string_search.hpp Show resolved Hide resolved
be/src/runtime/string_search.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/mem_util.hpp Show resolved Hide resolved
be/src/util/time_util.hpp Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stdpain stdpain enabled auto-merge (squash) January 11, 2023 10:53
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Jan 11, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@stdpain stdpain merged commit 9a1d6fa into StarRocks:main Jan 11, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chaoyli chaoyli chaoyli approved these changes

@stdpain stdpain stdpain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueeyu @wanpengfei-git @stdpain @chaoyli