Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Kotlin Gradle Plugin dependency #657

Merged
merged 2 commits into from
Jul 20, 2023
Merged

✨ Add Kotlin Gradle Plugin dependency #657

merged 2 commits into from
Jul 20, 2023

Conversation

MaxMichel2
Copy link
Contributor

Hello/bonjour,

What?

Adds Kotlin Gradle Plugin dependency

Why?

Quality of life for Android developers (Why have only AGP and not Kotlin?)

How?

Added module to Kotlin Dependency Group

Testing?

Ran check on both sample-android and sample-groovy

LouisCAD
LouisCAD approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I actually missed it myself several times.
Thank you!

@LouisCAD LouisCAD merged commit 7dff49c into Splitties:main Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisCAD LouisCAD LouisCAD approved these changes

@jmfayard jmfayard Awaiting requested review from jmfayard jmfayard is a code owner

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxMichel2 @LouisCAD