Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos found in docs/refreshversions-bot.md. #656

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

sintario
Copy link
Contributor

@sintario sintario commented Jan 24, 2023

I found trivial typos in docs/refreshversions-bot.md so let me fix them.

What?

Just fixed typos.

Why?

To be consistent.

How?

Replaced Verions with Versions.

Testing?

I just read the doc again after updated. 😄
I applied fixed version of .github/workflows/refreshVersions.main.kts to my project and confirmed it worked rightly.

@sintario sintario changed the title fixed typos found in docs/refreshversions-bot.md. Fixed typos found in docs/refreshversions-bot.md. Jan 24, 2023
@sintario sintario marked this pull request as ready for review January 24, 2023 02:52
Copy link
Member

@jmfayard jmfayard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your correction!

@jmfayard jmfayard merged commit 438fa08 into Splitties:main Jan 24, 2023
@LouisCAD
Copy link
Member

Hello,
I believe this change should have targeted the release branch since it's documentation-only.

See the contributing guide for docs here @jmfayard and @sintario : https://jmfayard.github.io/refreshVersions/contributing/improving-docs/

@sintario sintario deleted the patch-1 branch January 27, 2023 03:38
@sintario
Copy link
Contributor Author

Oh thanks for pointing it out, I've missed the guide. I would appreciate if my patch would be cherry-picked to the release branch. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants