Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-593] Dependency notations for CashApp: Molecule #594

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

thederputy
Copy link
Contributor

@thederputy thederputy commented Sep 8, 2022

Hello/bonjour, I've added a new CashApp library, Molecule.

What?

Resolves #593

Why?

To resolve #593

How?

Implemented the CashApp Molecule library.

Testing?

  • Ran ./gradlew check
  • Published to maven local, and consumed in a project locally
  • Tested all dependencies using sample-android, sample-groovy, and sample-kotlin

@LouisCAD
Copy link
Member

LouisCAD commented Sep 9, 2022

Hello, thanks for the PR!
I don't think we want the Paparazzi Gradle plugin as it can be used with just its id and we support the plugin.id.of.the.plugin=x.x.x syntax in the versions.properties, which is short and non-rendundant enough to not require built-in dependency notation.

For the merge conflicts, you probably want to undo you commit locally (should keep the changes), then remove edits to the docs/dependencies-notations.md file, then merge the latest main into your branch, and then commit your changes again (with just Molecule).

[Summary]
Molecule is a library for building `StateFlow` or `Flow` using Jetpack Compose (not Compose UI)

[Testing]
- Run project tests
- Publish to maven local and consume locally
@thederputy
Copy link
Contributor Author

Thanks for the feedback! I've updated it so that it is only adding Molecule and rebased on top of the latest main from the original repo.

@thederputy thederputy changed the title [Issue-593] Dependency notations for CashApp: Molecule and Paparazzi [Issue-593] Dependency notations for CashApp: Molecule Sep 10, 2022
@LouisCAD LouisCAD merged commit 05d01c2 into Splitties:main Sep 10, 2022
@LouisCAD
Copy link
Member

Thank you!

@thederputy thederputy deleted the app-cash-molecule branch September 10, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency notations for CashApp: Molecule
2 participants