Update Google accompanist modules #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the PR. Why did you revert changes to test resources? |
Hello, I thought it was breaking the test 🤔 |
|
@rlatapy-luna nope the tests are here to prevent you from typos and so on. It seems that there are more libraries than what your PR contains. Can you add them too and run the tests please? |
rlatapy-luna
force-pushed
the
add_accompanist-placeholder
branch
from
d2249cc
to
27e8c3c
Compare
rlatapy-luna
changed the title
I added missing accompanist lib and removed deprecated ones (glide & imageloadingCore) |
rlatapy-luna
force-pushed
the
add_accompanist-placeholder
branch
from
685bbbe
to
831912c
Compare
|
Thanks for updating! |
Co-authored-by: Louis CAD <[email protected]>
LouisCAD
force-pushed
the
add_accompanist-placeholder
branch
from
831912c
to
2b906fa
Compare
LouisCAD
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.