Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:refreshVersionsMissingEntries allows to migrate an existing projet #362

Merged
merged 11 commits into from
Jun 16, 2021

Conversation

jmfayard
Copy link
Member

@jmfayard jmfayard commented May 29, 2021

🚀 Description

Add a task refreshVersionsMissingEntries that populates the versions.properties file with all hardcoded versions, including plugins.

This is mostly a refactoring of something that was done inside :buildSrcLibs

I have a magic regex to make the build use the placeholder version here ==> https://regexr.com/5ti1j

🧪 How Has This Been Tested?

It was tested in projects like

✅ Checklist

Copy link
Member

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the issue templates needs be done directly on the main branch, or in a dedicated PR, because they are not related in any way to the title of this PR.
Same for the removal of the PR template.

There's currently a bigger problem in this PR: it reverts the lint updater code and all the tests.

Please, ensure that the diff is only what makes the refreshVersionsMissingEntries work and tested.

Also, I don't think the changes to the versions.properties file of the sample-multi-modules are necessary or needed for this PR.

Finally, I see that there's the version catalogs feature enabled for that same sample, but I don't think it should be in this PR either.

As you can see, I'm up late, which mean I'll not be able to get back to this for 9 hours at the very least (so 1PM+), plus you know I work on another project. Consequently, if you want this to be merged rather sooner than later, try to make this PR as perfect as you can before re-requesting my review 🙂

@jmfayard jmfayard force-pushed the refreshVersionsMissingEntries branch from b5bc91f to 350dac6 Compare May 30, 2021 11:10
@jmfayard
Copy link
Member Author

@LouisCAD sorry for the git mess. It should be all good now. Famous last words.

@jmfayard jmfayard added this to Louis review priority list in Priorities 📝 Jun 9, 2021
@jmfayard jmfayard mentioned this pull request Jun 10, 2021
@jmfayard jmfayard force-pushed the refreshVersionsMissingEntries branch from f788a44 to a6e87e4 Compare June 16, 2021 18:38
@jmfayard jmfayard force-pushed the refreshVersionsMissingEntries branch from 6ba15ce to 7a7ba73 Compare June 16, 2021 18:55
@jmfayard jmfayard merged commit 10fbd3f into main Jun 16, 2021
Priorities 📝 automation moved this from Louis review priority list to Done Jun 16, 2021
@jmfayard jmfayard deleted the refreshVersionsMissingEntries branch June 16, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants