-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify setup #159
Simplify setup #159
Conversation
refreshVersions/src/main/kotlin/org/gradle/kotlin/dsl/bootstrap.kt
Outdated
Show resolved
Hide resolved
@LouisCAD regarding to the package issue
I think this equally applies to using the root package, so I moved it simply to |
I think if we have a name that is very unique for the bootstrap symbols, using the root package is less of an issue as there would be no clash with future Gradle APIs, buildSrc code or other dependencies using root package as well. |
We don't need to use the root package, IntelliJ auto-improts flawlessly the extension fuction if you don't put the import. |
> Configure project : :sample-kotlin:implementation found hardcoded dependencies [guava, guice, okhttp] See #160
# Conflicts: # dependencies/gradle.properties # dependencies/src/test/resources/dependencies-mapping-validated.txt # dependencies/versions.properties # refreshVersions/plugins_version.txt # refreshVersions/src/main/kotlin/de/fayard/versions/PluginsManagementSetup.kt # sample-groovy/settings.gradle # sample-kotlin/settings.gradle.kts # sample-kotlin/versions.properties
I merged master into this branch now that there's a file format and exposed API for version keys (#161), and I fixed the merge conflicts. I'm in the process of reviewing locally, fixing what needs to be fixed, before this can be merged and released. |
I noticed I'll work on a solution for that in this PR, or revert that part, so it's being worked on in another PR, after this one is merged. |
…for new dependency with placeholder
Also, the changes broke dependencies rewrite as you can see the version placeholder stays in the publication as the GitHub actions failure shows. Edit: Found the root cause, it is because the dependencies plugin has not been upgraded to the latest version of refreshVersions despite having its property removed. |
refreshVersions/src/main/kotlin/de/fayard/versions/internal/VersionsPlaceholdersReplacement.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now ready to be published, I'll merge it.
Next up are:
- Documenting what we have
- Easing migration towards refreshVersions
- Remove old implementation to clear up the codebase
- Ditch versions sorter and keep order or maven-metadata, sorting the results in the order of the repos declaration.
- Simplifying setup of the dependencies plugin, so we can have a bootstrap that enables it along with refreshVersions?
Changelog
🎉 Make the new updater the default
✨ Bootstraping refreshVersions #155
The setup for Groovy should now be:
The setup for Kotlin should now be: