Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-538] Dependency notations for Ktor 2.0.0 #542

Closed

Conversation

brady-aiello
Copy link
Contributor

What?

Resolves #538

Adding dependency notations for Ktor 2.0.0

Why?

Ktor 2.0.0 renames a significant number of dependencies, adds new ones, and moves some previously available ones from 1 module into another. It makes sense to make a separate repo for Ktor 2. The full list of artifact changes between 1.6.x and 2.0.0 can be found here:
https://ktor.io/docs/migrating-2.html

How?

Create a Ktor2 dependency group, and include all dependencies listed in the docs:

Ktor 2.0.0: https://api.ktor.io/index.html

Ktor 1.6.8: https://api.ktor.io/older/1.6.8/index.html

Testing?

  • Run project tests
  • publish to maven local, and consume in a project locally

[Summary]
Ktor 2.0.0 renames a significant number of dependencies, adds new ones,
and moves some previously available ones from 1 module into another. It
makes sense to make a separate repo for Ktor 2. The full list of
artifact changes between 1.6.x and 2.0.0 can be found here:
https://ktor.io/docs/migrating-2.html

[Fix]
Create a Ktor2 dependency group, and include all dependencies listed in
the docs:

Ktor 2.0.0: https://api.ktor.io/index.html

Ktor 1.6.8: https://api.ktor.io/older/1.6.8/index.html

[Testing]
- Run project tests
- publish to maven local, and consume locally
@brady-aiello
Copy link
Contributor Author

Example usage:

Screen Shot 2022-05-02 at 5 29 18 PM

@brady-aiello
Copy link
Contributor Author

@LouisCAD pinging to see your thoughts

@jmfayard
Copy link
Member

jmfayard commented Jul 2, 2022

Thanks @brady-aiello I have merged your changes via #559

@jmfayard jmfayard closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency notations for Ktor 2.0.0
2 participants