Add new Kotlin dependencies #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some new Kotlin dependencies and their version aliases.
Ran the check task and tested on sample-android.
Added Kotlin deep learning dependencies and its version alias.
Ran check and tested using sample-android.
LouisCAD
requested changes
Mar 3, 2022
There was a problem hiding this comment.
Hello, thanks for the PR!
I noticed that you're not using PascalCase as we do in other places for Dataframe and Deeplearning. Please use it.
Before committing your changes, you'll need to undo your edits to the following files:
dependencies-mapping-validated.txtdependencies-versions-key-validated.txtbundled-dependencies-validated.txt
Once this is done, you can run the checks again so that they update the files properly, and then you can commit and push.
|
Thanks @imashnake0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello/bonjour, I've added the new Kotlin dependencies from #498.
What?
Resolves #498.
Why?
To resolve #498.
How?
Added the four dependencies in #498.
Testing?
versions.properties../gradlew check.