This repository has been archived by the owner on May 6, 2021. It is now read-only.
LDAP-49 : Fix for Com4jException thrown by external users provider #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. AdConnectionHelper now connects to domain LDAP servers instead of forest GC ( Global Catalog) servers to get the users details. 2. More logging is added in AdConnectionHelper and WindowsAuthenticationHelper 3. More exception handling is added in AdConnectionHelper to catch exceptions thrown by Com4j. 4. Unit tests are also updated. Manual Testing of scenarios ( Compat mode and and non-compat mode windows authentication ) 1. Test on corpnet in which GC servers are available. 2. Testing on private active directory setup in which a. Two domains in same forest and AD global catalog is not present in both the domains. Windows auth for users from both domain to SonarQube server in one of the domain. b. Two domains in the same forest and AD global catalog is present for one of the domains. Windows auth for users from both domain to SonarQube server in one of the domain. c. Two domains ( sub-tree of third domain). Windows auth for users from both domain to SonarQube server in one of the domain.
|
Looks good to me. |
sulabh-msft
added a commit
that referenced
this pull request
Nov 25, 2015
LDAP-49 : Fix for Com4jException thrown by external users provider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forest GC ( Global Catalog) servers to get the users details.
WindowsAuthenticationHelper
catch exceptions thrown by Com4j.
Manual Testing of scenarios ( Compat mode and and non-compat mode
windows authentication )
a. Two domains in same forest and AD global catalog is not present
in both the domains. Windows auth for users from both domain to
SonarQube server in one of the domain.
b. Two domains in the same forest and AD global catalog is present
for one of the domains. Windows auth for users from both domain to
SonarQube server in one of the domain.
c. Two domains ( sub-tree of third domain). Windows auth for users from
both domain to SonarQube server in one of the domain.