This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Refactor shell extension to include permitted guilds check #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e guild is permitted to use shell commands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the shell extension in the codebase to include a check for permitted guilds before processing shell commands. It introduces a new configuration file (
config.yml) to store the list of permitted guilds. Thedoshellmethod in theShellclass now checks if the guild ID is in the list of permitted guilds and responds with an error message if the guild is not allowed to use shell commands.Summary of Changes
bot/src/exts/shell.pyto include logic for checking permitted guilds in thedoshellmethod.bot/config.ymlto store the list of permitted guilds.bot/config.ymlto list the guild IDs that are allowed to use shell commands.Fixes #48.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.