-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Get #644
Added Get #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Thanks for that.
@Solido Look at this package: https://pub.dev/packages/get |
Hi ! thx for protecting us from cliche code ;) |
Btw this may cause issues for flutter web: return Platform.isIOS
? key.currentState.push(GetCupertino(
opaque: rebuildRoutes ?? true,
page: page,
transition: transition ?? Transition.cupertino,
duration: duration))
: key.currentState.push(GetRoute(
opaque: rebuildRoutes ?? false,
page: page,
transition: transition ?? Transition.fade,
duration: duration));
}
I’m of two minds about his package. I think it is a great fix for the short term, but could cause problems with apps as it is harder to predict when navigation happen. Which is fine, but something to be aware of. But I also like the flexibility and the ability to control navigation from a bloc for example. That being said this will all be resolved when the new navigator lands and is a new declarative api yo navigation instead of imperative: Really love the package though. Side note is the name is confusing, it immediately made me think of get_it and not a navigation style package. |
Thanks for remembering that, I inserted this code in the dev / master branch of Get and forgot about Flutter web and desktop. I'm looking forward to the new Flutter navigation, the idea of the lib was to get rid of a materialApp reconstruction bug that destroyed the performance of my biggest app, but it seems that Godebauer already fixed it in the master, if there was no regression in PR his. However, snackbars are still boring with standard navigation. |
Hi, due to bugs in the named FlutterWeb routes of the Dev/Master version (sending an empty path in onGenerateRoute on initialRoute), I had to rebuild Get with a MaterialApp wrapper to handle named routes and more other resources before arriving at MaterialApp, as a temporary hotfix for this, as some of the library's customers are using Flutter web in production. I took advantage that it was a break update, added a new state manager similar to the provider's Consumer, but that does not use changeNotifier (which is terrible for performance) and that uses very little memory. I believe that the plugin has turned into a microframework, and is having a great acceptance in the community (only this week it has increased +80 stars), for being highly stable, and providing resources in an unclopped way, facilitating unit tests with Flutter. |
Hi ! yes one PR per resource please ! |
Navigate between screens, display snackbars, dialogs and bottomSheets, from anywhere in your code without context with Get.
You've read How to contribute right ? yes
So tell me more about your awesome contribution and add the badge to your repo after it's accepted :D ok