Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Underlords Guru to Open Source Apps #568

Closed
wants to merge 1 commit into from
Closed

Add Underlords Guru to Open Source Apps #568

wants to merge 1 commit into from

Conversation

trankhacvy
Copy link

Underlords Guru is unofficial guide app for Dota Underlords. Using flutter with beautiful UI and smooth animation.

Repo: https://github.com/Levi-ackerman/underlords-guide

Copy link
Collaborator

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Levi-Ackerman

Nice project you worked on there. I have gone through your repo and correct me if I'm wrong but I don't know if it in any way architecturally different from the other open source projects currently on the list.

@trankhacvy
Copy link
Author

@jogboms You're right. I use https://github.com/KingWu/flutter_starter_kit in the beginning.
My repo mainly focus on UI and animation.
In the future, I will re-structure my app and add state management.

@jogboms
Copy link
Collaborator

jogboms commented Nov 17, 2019

Very well. I will close this for now. Please feel free to reopen a new one at that point. 💙

@jogboms jogboms closed this Nov 17, 2019
@trankhacvy
Copy link
Author

@jogboms Thanks. Just wonder do we have any specific rules for accepting the pull request. I mean about coding standard or app structure .. etc

@jogboms
Copy link
Collaborator

jogboms commented Nov 17, 2019

Hey @Levi-Ackerman, no laid-out specific rules per se. As long as it doesn't exactly repeat what someone else has done but something awesome, maybe a rethink, a deep dive or even something entirely new. :)
See contributing.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants