Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jugger.dart. Dependency Injection for Flutter and Dart #551

Closed
wants to merge 1 commit into from

Conversation

ivk1800
Copy link

@ivk1800 ivk1800 commented Nov 4, 2019

This is a package I created. I did not find a package with a similar implementation among the available ones, except as an inject.dart, but it has not been updated for a long time and there is no guarantee what will happen in the future.

Copy link
Collaborator

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivk1800
Copy link
Author

ivk1800 commented Nov 7, 2019

@jogboms my implementation is similar to dagger 2 and android developers will be easier and faster to use the library

@jogboms jogboms added the Observation Test of time label Nov 8, 2019
@jogboms
Copy link
Collaborator

jogboms commented Nov 17, 2019

Hey @ivk1800

Sorry to rain on the parade but does it offer anything fundamentally different from google's inject? You mentioned it hasn't been updated in 6 months. Technically, its not the sort of package that would get that much update unless there is an architectural change in the design.

@ivk1800
Copy link
Author

ivk1800 commented Nov 17, 2019

@jogboms I am using different algorithm for generation. Jugger it is not fork of inject.dart. My lib can be used right now.

@jogboms
Copy link
Collaborator

jogboms commented Nov 17, 2019

Hey @ivk1800
My point is, it's trying to do the same thing that has already been done and its without tests and a lot of TODOs. I added the Observation label to see how far it goes with the test of time but I am just curious to know if its a worthy endeavour going forward.

@Solido
Copy link
Owner

Solido commented Jan 4, 2020

No traction from the community.
Thanks for PR !

@Solido Solido closed this Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Observation Test of time
Projects
None yet
3 participants