Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audioPlayers plugin to readMe - edited source #504

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

subhash279
Copy link
Contributor

Hi,

This plugin provides a simple way to play multiple audio files simultaneously on android and ios. The examples are here - https://github.com/luanpotter/audioplayers.
Many features like setting playback rate, showing audio in notification area for ios are available.
I think it will be useful to lot of people.

I edited the source file according to the guidelines now.

Thanks,

@subhash279
Copy link
Contributor Author

Hi,
Just checking if this is merged into the main branch.
Thanks!

@subhash279
Copy link
Contributor Author

Hi, I resolved any conflicts within the branches. Please merge it if possile.
Thanks!

Copy link
Collaborator

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @subhash279

I noticed its an improved fork but is there any particular reason it wasn't contributed back to the original repository?

@subhash279
Copy link
Contributor Author

Hi @jogboms I am not sure actually why this wasn't merged. It doesn't even have any merge conflicts. Can you pls merge it if possible. Thanks.

@jogboms
Copy link
Collaborator

jogboms commented Nov 5, 2019

Hey @subhash279

I mean, at this point, I know both libraries have diverged much but I was just wondering as a fork, why it was never merged back to the source as a PR instead of an entirely new library sharing literally the same name?

PS. you didn't author the library, I know.

@jogboms jogboms added the Observation Test of time label Nov 5, 2019
@subhash279
Copy link
Contributor Author

Hi @jogboms I am not entirely sure as you said I am not the author and only a contributor. But I think this has many more features than the original one and I think lots of code was rewritten as well.

@jogboms
Copy link
Collaborator

jogboms commented Nov 5, 2019

True. I added the label to look more into it. Thanks

@subhash279
Copy link
Contributor Author

@jogboms thanks. Also as you may have already noticed it already has more than 460 stars on its own as a new repo.

@jogboms
Copy link
Collaborator

jogboms commented Nov 6, 2019

True @subhash279 with a bit more open issues too :)

@Solido Solido merged commit d48fea5 into Solido:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Observation Test of time
Projects
None yet
3 participants