Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Invoice Ninja #117

Closed
wants to merge 1 commit into from
Closed

Add Invoice Ninja #117

wants to merge 1 commit into from

Conversation

hillelcoren
Copy link
Contributor

No description provided.

@Solido
Copy link
Owner

Solido commented Jun 19, 2018

Nice app but nothing special to complete the curation. Keep the good work.

@Solido Solido closed this Jun 19, 2018
@hillelcoren
Copy link
Contributor Author

Ok, understood.

Just so you're aware, our app provides 100% state persistence. If a user is part way through creating a record all details are saved in realtime and loaded after the app is restarted. This is implemented by persisting our Redux store in parts. You can read more about it here:

https://hillelcoren.com/2018/06/18/flutter-using-redux-to-manage-complex-forms-with-multiple-tabs-and-relationships/

No worries if you don't think it should be included, just trying to do my part sharing our code :)

@hillelcoren
Copy link
Contributor Author

hillelcoren commented Jun 19, 2018

One other point I think is worth mentioning.

None of the Redux examples are using sourcegen to handle immutability. It would be extremely difficult to build a large Redux app without it. I know, I tried...

We're use the built_value package which auto generates all of the model code. It's what enables our persistence.

https://github.com/invoiceninja/flutter-mobile/blob/master/pubspec.yaml#L8

@hillelcoren
Copy link
Contributor Author

Before I create the PR, would you accept this library under Utilities?

https://github.com/hillelcoren/flutter-redux-starter

I still think the app should be added, maybe a video will change your mind...

@hillelcoren
Copy link
Contributor Author

@Solido ??

@Solido
Copy link
Owner

Solido commented Jul 2, 2018

Sorry for the late response when closed an issue doesn't trigger notification anymore...

I really love coding generator. Yours seems like a good base for becoming the new yeoman ?

Please PR using source.md

Thank you 👍

@Solido Solido reopened this Jul 2, 2018
@Solido Solido closed this Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants