Potential fix for other layers bed temperature not applied #5546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On occasion the second layer bed temperature was not set according to the filament preferences. This PR aims to introduce a fix for this. This issue seems to have been present since v1.6.4 or earlier.
This is a particularly difficult one to reproduce as it doesn't happen repeatably.
Requesting community testers to validate the fix.
Test needed:
To see the Gcode window press key "C" on your keyboard. Navigate using the sliders to the second layer and at the start of it as shown in the screenshots below.
Asking for testers as its been particularly difficult to a) replicate that the issue is happening as its sporadic and b) validate that the fix is working.
When testing please confirm with your existing installation that the issue is happening first before trying the PR build. Please comment back below on whether a) it happened to you in the current build you're using alongside the version number you're running and b) if this PR fixed it or not.
When it works it should look like the below (line 774)
![image](https://private-user-images.githubusercontent.com/59056762/335830084-fb502a04-1945-4e23-8a62-e9348ba0e84f.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNTcxNzksIm5iZiI6MTcyNjA1Njg3OSwicGF0aCI6Ii81OTA1Njc2Mi8zMzU4MzAwODQtZmI1MDJhMDQtMTk0NS00ZTIzLThhNjItZTkzNDhiYTBlODRmLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQxMjE0MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zZDM5OTk0MWFjZjIxYjIxNWQ2ZjNiZWRhZjhlYjgwNTYxODQxYjFjZDllNzQ0NmI1YmIwYWMzMTU3OGIxNTcxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.DobOdsR_VP3oLWhwW1ScA89pe8G3-NPYhEjgchjRQI8)
If it doesn't work it will look like this (line 773 only, no set bed temperature present)
![image](https://private-user-images.githubusercontent.com/59056762/335830108-a6a2b04d-8865-4096-a1f3-f175c851051c.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNTcxNzksIm5iZiI6MTcyNjA1Njg3OSwicGF0aCI6Ii81OTA1Njc2Mi8zMzU4MzAxMDgtYTZhMmIwNGQtODg2NS00MDk2LWExZjMtZjE3NWM4NTEwNTFjLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQxMjE0MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMWVmMTY4ODQ4MmVkYjI2MWU3MGZiYjUyMzZhNDZkYzQ1ZDFhNDdhZjgyM2I0ZTE0ZGRkZjg5YjQ2N2Y4ZTg2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.pFMOdRv2mSjXXAQrdKxQNBajCd5nJ8yDy9G65e6v6hE)
Tests performed
As above.
I think that this PR also causes the bed temperature to always be set on the second layer but this also needs testing... Whether this is an issue or not remains open for discussion as its an extra Gcode command that is not needed but not harmful as the printer is already operating at that bed temperature so it will be just ignored.
Fixes #5485
Fixes #4676
Fixes #3015
Fixes #1853