Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: restore single instance #4810

Merged
merged 3 commits into from
Apr 20, 2024
Merged

ENH: restore single instance #4810

merged 3 commits into from
Apr 20, 2024

Conversation

noobydp
Copy link
Contributor

@noobydp noobydp commented Mar 31, 2024

Single instance setting was recently added back to BambuStudio.
(See bambulab/BambuStudio@809f82b)

I have replicated the changes and tested on Windows manually opening STL files and also exporting to orca from Fusion 360.

I am unable to test Linux or Macos

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noobydp
Could you take a look at the conflicts?

@noobydp
Copy link
Contributor Author

noobydp commented Apr 17, 2024

I think I've done it, but I've never had to resolve a conflict on a PR before so please tell me if I got it wrong.

@Ocraftyone
Copy link
Contributor

Awesome! This is something that I had on my list of things to do. One problem is that on WSL2 Ubuntu with single instance enabled I get a dbus error.

dbus[1342262]: arguments to dbus_message_new_method_call() were incorrect, assertion "iface == NULL || _dbus_check_is_valid_interface (iface)" failed in file ../../../dbus/dbus-message.c line 1367. This is normally a bug in some application using the D-Bus library. D-Bus not built with -rdynamic

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@SoftFever SoftFever merged commit 2b4520b into SoftFever:main Apr 20, 2024
12 checks passed
@Ocraftyone
Copy link
Contributor

Ocraftyone commented Apr 20, 2024

@SoftFever did you get the Linux default tol or is that a WSL thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants