Bug: Fix retraction issues with PA pattern calibration #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
|
Fixed the second bug with the dual retractions and deretractions. @SoftFever PR ready for review. This needs a second pair of eyes to cross check it, with both relative and absolute extrusion enabled. |
SoftFever
reviewed
Jan 8, 2024
SoftFever
reviewed
Jan 8, 2024
|
crash fixed. ready for review :) |
SoftFever
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Attempt to fix retraction issues with PA pattern calibration * PA pattern test fix - retract and wipe on layer change * Naming convention * fix crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #3154 and #3031
Also fixed issue due to retract on layer change being enabled causing two de-retractions when starting the handle cube. And also two retractions when starting the PA lines which results in the first line (or more) being not extruded.