Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes not disappearing holograms caused by delayed hologram placement when called from async ( #3176 (comment) )
Proposed changes
HologramsService#updateHologram
to allows calls only from sync code. Calls from async code should not be allowed as this on its own causes undefined behaviour. For example theHologramsService#removeHologram
function already does not allow async.HologramOwner#updateHologram
to allow calls from async code. ChecksisDeletedSoon
to be sure that the hologram owner still exists.Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values