Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silent give command #4196

Closed
wants to merge 2 commits into from
Closed

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented May 24, 2024

Description

Adds a silent_give command to give items to players without notifying them.

Proposed changes

Move the logics to AbstractGiveCommand, and pass arguments to determine whether the receiver should get a notification.

Related Issues (if applicable)

Discord suggestion 2579

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner May 24, 2024 20:24
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: a1bd9c8a

https://preview-builds.walshy.dev/download/Slimefun/4196/a1bd9c8a

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@JustAHuman-xD
Copy link
Contributor

Is there a reason for the class being abstract here? if all you are changing is the constructer arguments then the class doesn't need to be abstract, just have a give command that's created twice with the corresponding silent and not silent arguments. unless I'm missing something anyways

@ybw0014
Copy link
Contributor Author

ybw0014 commented May 30, 2024

Is there a reason for the class being abstract here? if all you are changing is the constructer arguments then the class doesn't need to be abstract, just have a give command that's created twice with the corresponding silent and not silent arguments. unless I'm missing something anyways

to keep the SlimefunSubCommands format consistent.
image

@JustAHuman-xD
Copy link
Contributor

to keep the SlimefunSubCommands format consistent. image

Hmmmm, like fair but also aaaaaa

@ybw0014
Copy link
Contributor Author

ybw0014 commented May 31, 2024

Hmmmm, like fair but also aaaaaa

I would like to see others' opinions.

@ybw0014 ybw0014 closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants