Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/energy regulator gui #4188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Intybyte
Copy link
Contributor

Description

On right click of an energy regulator display the consumers and info about their state.

Proposed changes

Saw on the #approved suggestions of the discord the suggestion number #2255 and I decided to implement it.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner May 10, 2024 12:27
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label May 10, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@J3fftw1
Copy link
Contributor

J3fftw1 commented May 10, 2024

I don’t know if it’s smart to add another block with an inventory without any actual use.

I do appreciate the PR but I’m not sure if it’s smart to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants