-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disappearing sensitive blocks on slimefun blocks #3184
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sensitive_materials.json
uses tabs instead of spaces, now might be a good time to switch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing amethyst in the list of newly added items.
If this is fixed this will fix a bug in CrystamaeHistoria.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry about the delay, I think this is missing lanterns. Other than that looks good
Co-authored-by: Sfiguz7 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking this until I get a chance to look over the code.
Honestly, some code documentation could help 😬
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BlockListener.java
Outdated
Show resolved
Hide resolved
Closing this PR for now. We need to find a better solution for this bug. |
I do think this would be a good fix even if its a temporarily fix since it now breaks some things in core sf and the addons. |
But there is also a bug where blocks that are attached on the side of slimefun block e.g. banner won't drop. This fix will be harder to implement. |
Yea fair their will always be edge cases and will always be pain to update. But i think the changes you made should still be applied |
Ah, you convinced me |
Since you reopened it, it would be nice to support 1.19 blocks aswell. |
and maybe we need to think of a way to support wall blocks like banners torches paintings etc, |
There is a cool method in bukkit |
Mmh my message apparently didnt send yesterday. We should probably look in a way to just send physics updates to blocks around it. Not sure if thats have at all since we need all sides of the block being updated. Edit; from quickly glancing over the code it seems like we dont send physics update. Im also not sure how heavy that is to send to 6 blocks each time a slimefun blocm is broken. |
Description
Fix disappearing sensitive blocks on slimefun blocks
Proposed changes
BlockListener#dropItems
callse.setDropItems(false)
which also cancels drops from sensitive block above.I added to
BlockListener#checkForSensitiveBlockAbove
check for non-slimefun sensitive blocks.I also added some other sensitive materials to
sensitive_materials.json
.Related Issues (if applicable)
Resolves #3182
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values