Build system tweaks #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building with protobuf installed from vcpkg (on my machine). In the interest of making minimal changes, I've turned on the flag to make it compatible with FindProtobuf instead of using the current API of protobuf_generate (which I did in the feeder app).
Again, in the interest of minimal changes, I've not touched anything else. openvr can for sure be grabbed via vcpkg, linalg probably can as well. I've adjusted CI to not explicitly grab protobuf, hopefully that works.
Eirenliel
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a minor change that fixes protobuf on my system, and a more major one of using vcpkg's manifest mode (as reccomended in their documentation). The latter means that dependencies from vcpkg are automatically grabbed when cmake configuration is done.
It occurs to me that perhaps the comment in the cmake file about installing protobuf is no longer necessary.
I've kept my changes as minimal as possible, by which I mean that I've not adjusted the other library dependencies to run through vcpkg, and I haven't adjusted how we call protobuf in our cmake script. If desirable, these are changes we can make in the future.