Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CMake #861

Closed
wants to merge 2 commits into from
Closed

Cleanup CMake #861

wants to merge 2 commits into from

Conversation

hjmjohnson
Copy link
Member

Minor cleanups to cmake to conform to modern language preferences.

Ancient versions of CMake required else(), endif(), and similar block
termination commands to have arguments matching the command starting the block.
This is no longer the preferred style.
Ancient CMake versions required upper-case commands.  Later command names
became case-insensitive.  Now the preferred style is lower-case.
@jcfr
Copy link
Member

jcfr commented Jan 10, 2018

Thanks 👍

Integrated in r26822 and r26823

@jcfr jcfr closed this Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants