Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum required cmake #765

Closed
wants to merge 2 commits into from
Closed

Update minimum required cmake #765

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2efbc9c
COMP: Update CMake minimum required version from 2.8.9 to 3.5
jcfr Aug 3, 2017
94281a8
COMP: cmake_minimum_required -> 3.5
jcfr Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
COMP: cmake_minimum_required -> 3.5
  • Loading branch information
@jcfr
jcfr committed Aug 3, 2017
commit 94281a87984867f8130cf6929433ab6af52e747b
2 changes: 1 addition & 1 deletion CMake/ListToString.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#
################################################################################

cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

function(list_to_string separator input_list output_string_var)
set(_string "")
Expand Down
2 changes: 1 addition & 1 deletion CMake/SlicerConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
# ConfigurePrerequisites | Slicer_USE_CONFIGUREPREREQUISITES
# --------------------------------------------------------------------------

cmake_minimum_required(VERSION 3.3)
cmake_minimum_required(VERSION 3.5)

foreach(component NoExtensionSupport ConfigurePrerequisites)
string(TOUPPER ${component} _COMPONENT)
Expand Down
2 changes: 1 addition & 1 deletion CMake/SlicerDashboardScript.TEMPLATE.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# 'glxinfo | grep OpenGL' to obtain GPU details.
####################################################################################

cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

#
# For additional information, see http:https://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/DashboardSetup
Expand Down
2 changes: 1 addition & 1 deletion CMake/SlicerExtensionCPack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ if(APPLE)
# for SuperBuild extensions.

file(WRITE ${slicer_extension_cpack_bundle_fixup_directory}/CMakeLists.txt
"cmake_minimum_required(VERSION 3.0)
"cmake_minimum_required(VERSION 3.3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentionally just 3.3 and not 3.5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This one should be updated.

install(SCRIPT \"${slicer_extension_cpack_bundle_fixup_directory}/SlicerExtensionCPackBundleFixup.cmake\")")
set(source_dir "${slicer_extension_cpack_bundle_fixup_directory}")
set(build_dir "${slicer_extension_cpack_bundle_fixup_directory}-binary")
Expand Down
2 changes: 1 addition & 1 deletion CMake/UseSlicerMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.3)
cmake_minimum_required(VERSION 3.5)

# Given a variable name, this function will display messages indicating what the current
# value of the variable.
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

cmake_minimum_required(VERSION 3.3)
cmake_minimum_required(VERSION 3.5)
cmake_policy(SET CMP0017 OLD)

#-----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Extensions/CMake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 3.3)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

if(Slicer_SOURCE_DIR)
Expand Down
2 changes: 1 addition & 1 deletion Extensions/CMake/SlicerExtensionsDashboardScript.TEMPLATE.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# 'glxinfo | grep OpenGL' to obtain GPU details.
####################################################################################

cmake_minimum_required(VERSION 2.8.7)
cmake_minimum_required(VERSION 3.5)

#
# For additional information, see http:https://http:https://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/DashboardSetup
Expand Down
2 changes: 1 addition & 1 deletion Extensions/CMake/Testing/CheckGeneratedDescriptionFiles.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Check that TestExtC generated description file is valid.
#

cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

# Sanity checks
set(expected_existing_vars
Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/CLIExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(CLIExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/EditorExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(EditorExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/LoadableExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(LoadableExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/ScriptedLoadableExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(ScriptedLoadableExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/ScriptedSegmentEditorEffectExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(ScriptedSegmentEditorEffectExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Extensions/Testing/SuperBuildExtensionTemplate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.5)

project(SuperBuildExtensionTemplate)

Expand Down
2 changes: 1 addition & 1 deletion Libs/FreeSurfer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(FreeSurfer)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/ITKFactoryRegistration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project(ITKFactoryRegistration)

cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)

# --------------------------------------------------------------------------
# Dependencies
Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/CLI/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(MRMLCLI)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/Core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(MRMLCore)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/DisplayableManager/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(MRMLDisplayableManager)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/IDImageIO/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(MRMLIDImageIO)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------


Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/Logic/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(MRMLLogic)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/MRML/Widgets/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ project(qMRMLWidgets)


#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/RemoteIO/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(RemoteIO)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/vtkAddon/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(vtkAddon)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/vtkITK/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(vtkITK)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/vtkSegmentationCore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(vtkSegmentationCore)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Libs/vtkTeem/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(vtkTeem)

#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 2.8.4)
cmake_minimum_required(VERSION 3.5)
#-----------------------------------------------------------------------------

# --------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion Utilities/Templates/Extensions/Default/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.9)
cmake_minimum_required(VERSION 3.5)

project(TemplateKey)

Expand Down
2 changes: 1 addition & 1 deletion Utilities/Templates/Extensions/SuperBuild/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.5)

project(TemplateKey)

Expand Down