COMP: Avoid symbol clash detecting system install of Qt. See #3573 #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If qmake is found in a system location, explicitly mark Qt as such. Doing so will prevent system path from being prepended to PATH or (DY)LD_LIBRARY_PATH when generating the launcher settings and avoid system libraries symbols from conflicting with Slicer version of these libraries.
jcfr
force-pushed
the
3574-detect-system-qt
branch
from
5194893
to
9b320db
Compare
|
Cc: @dzenanz |
msmolens
approved these changes
Aug 3, 2017
|
Thanks for the review |
|
Integrated in r26193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If qmake is found in a system location, explicitly mark Qt as such. Doing so
will prevent system path from being prepended to PATH or (DY)LD_LIBRARY_PATH
when generating the launcher settings and avoid system libraries symbols from
conflicting with Slicer version of these libraries.