Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Update libarchive version #759

Closed
wants to merge 1 commit into from

Conversation

pieper
Copy link
Member

@pieper pieper commented Aug 1, 2017

Previously we used a Slicer-specific fork of libarchive
with a few patches, but this got behind the main line
of development and eventually would not build on gcc-6.

This patch switches us to the most recently release of the
upstream repo.

Previously we used a Slicer-specific fork of libarchive
with a few patches, but this got behind the main line
of development and eventually would not build on gcc-6.

This patch switches us to the most recently release of the
upstream repo.
@pieper
Copy link
Member Author

pieper commented Aug 1, 2017

FYI I tested on linux and mac, but not on windows.

@jcfr
Copy link
Member

jcfr commented Aug 1, 2017

Well done. Testing on windows now.

@jcfr
Copy link
Member

jcfr commented Aug 1, 2017

Windows:

  • Build of LibArchive is successful
  • Now waiting for the remaining of the build to complete

@jcfr jcfr self-requested a review August 2, 2017 00:33
Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows build was 🆗
Windows package was also 🆗

@jcfr jcfr added the lgtm label Aug 2, 2017
@jcfr
Copy link
Member

jcfr commented Aug 2, 2017

Closing. This is superseded by #761

@jcfr jcfr closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants