Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update extension buildsystem to handle source dir without vcs #717

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Apr 27, 2017

This commit prevents extension generated using the wizard but not yet
associated with a source control system from failing to build with a
message like:

  -- Could NOT find Subversion (missing:  Subversion_SVN_EXECUTABLE)
  CMake Error at /path/to/Slicer/Extensions/CMake/SlicerBlockUploadExtension.cmake:38 (message):
    Variable Subversion_SVN_EXECUTABLE is set to an inexistent directory or
    file ! []
  Call Stack (most recent call first):
    /path/to/Slicer/Extensions/CMake/SlicerEnableExtensionTesting.cmake:23 (include)
    /path/to/Slicer-Release/Slicer-build/UseSlicer.cmake:421 (include)
    CMakeLists.txt:21 (include)

If an extension named Foo is not yet associated with a repository is
built, the following author warning is now reported:

  -- Configuring Scripted module: bar
  CMake Warning (dev) at /path/to/Slicer/CMake/SlicerMacroExtractRepositoryInfo.cmake:94 (message):
    Skipping repository info extraction: directory [/path/to/Foo] is not a GIT, SVN
    or CVS checkout
  Call Stack (most recent call first):
    /path/to/Slicer/CMake/SlicerExtensionCPack.cmake:55 (SlicerMacroExtractRepositoryInfo)
    CMakeLists.txt:45 (include)
  This warning is for project developers.  Use -Wno-dev to suppress it.

  -- Configuring done
  -- Generating done
  -- Build files have been written to: /path/to/Foo-build/inner-build

Reported-by: Matt McCormick [email protected]

@jcfr jcfr requested a review from thewtex April 27, 2017 20:47
This commit prevents extension generated using the wizard but not yet
associated with a source control system from failing to build with a
message like:

  -- Could NOT find Subversion (missing:  Subversion_SVN_EXECUTABLE)
  CMake Error at /path/to/Slicer/Extensions/CMake/SlicerBlockUploadExtension.cmake:38 (message):
    Variable Subversion_SVN_EXECUTABLE is set to an inexistent directory or
    file ! []
  Call Stack (most recent call first):
    /path/to/Slicer/Extensions/CMake/SlicerEnableExtensionTesting.cmake:23 (include)
    /path/to/Slicer-Release/Slicer-build/UseSlicer.cmake:421 (include)
    CMakeLists.txt:21 (include)

If an extension named Foo is not yet associated with a repository is
built, the following author warning is now reported:

  -- Configuring Scripted module: bar
  CMake Warning (dev) at /path/to/Slicer/CMake/SlicerMacroExtractRepositoryInfo.cmake:94 (message):
    Skipping repository info extraction: directory [/path/to/Foo] is not a GIT, SVN
    or CVS checkout
  Call Stack (most recent call first):
    /path/to/Slicer/CMake/SlicerExtensionCPack.cmake:55 (SlicerMacroExtractRepositoryInfo)
    CMakeLists.txt:45 (include)
  This warning is for project developers.  Use -Wno-dev to suppress it.

  -- Configuring done
  -- Generating done
  -- Build files have been written to: /path/to/Foo-build/inner-build

Reported-by: Matt McCormick <[email protected]>
@jcfr jcfr force-pushed the update-extension-build-system-to-handle-source-dir-without-vcs branch from 066dddd to 772aaff Compare April 27, 2017 20:48
@jcfr jcfr requested a review from ShusilDangi April 27, 2017 20:53
@jcfr
Copy link
Member Author

jcfr commented Apr 28, 2017

Thanks for the review. Integrated in r25984

@jcfr jcfr closed this Apr 28, 2017
@jcfr jcfr deleted the update-extension-build-system-to-handle-source-dir-without-vcs branch April 28, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants