ENH: Added opacity setting for 2D slice intersections #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
requested changes
Feb 20, 2017
| @@ -62,6 +62,8 @@ void qMRMLDisplayNodeWidgetPrivate::init() | |||
| Q_Q(qMRMLDisplayNodeWidget); | |||
| this->setupUi(q); | |||
|
|
|||
| this->SliceIntersectionOpacitySlider->setValue(1.0); | |||
There was a problem hiding this comment.
Remove this lines and set default value in .ui file instead
| { | ||
| Q_D(qMRMLDisplayNodeWidget); | ||
| if (!d->MRMLDisplayNode.GetPointer()) | ||
| { |
| d->SliceIntersectionOpacitySlider->setVisible(visible); | ||
| } | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
| void qMRMLDisplayNodeWidget::updateWidgetFromMRML() | ||
| { | ||
| Q_D(qMRMLDisplayNodeWidget); |
There was a problem hiding this comment.
Need to implement update of slice intersection opacity widget from MRML in updateWidgetFromMRML()
sjh26
force-pushed
the
Add2DSliceIntersectionOpacity
branch
from
7b989bb
to
5d175ec
Compare
|
Requested changes made and pushed! |
lassoan
approved these changes
Feb 23, 2017
| @@ -322,6 +324,12 @@ void vtkMRMLDisplayNode::ReadXMLAttributes(const char** atts) | |||
| ss << attValue; | |||
| ss >> Opacity; | |||
| } | |||
| else if (!strcmp(attName, "sliceIntersectionOpacity")) | |||
| { | |||
| Q_D(qMRMLDisplayNodeWidget); | ||
| if (!d->MRMLDisplayNode.GetPointer()) | ||
| { | ||
| return; |
sjh26
force-pushed
the
Add2DSliceIntersectionOpacity
branch
from
5d175ec
to
44a1438
Compare
|
Indentation fixed! |
agirault
approved these changes
Feb 27, 2017
|
Integrated in r25731. Thanks a lot Sam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: http:https://na-mic.org/Mantis/view.php?id=4334