BUG: Force image slice actors to be treated as opaque #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes rendering of image slices in the 3D view with the VTK OpenGL2 backend. The OpenGL2 backend performs more thorough checks than the old backend when determining whether to treat an actor as opaque or translucent. Now, in certain cases, VTK determines that the slice texture contains transparent elements and therefore should treat the actor as translucent, i.e. rendered without writing to the depth buffer. [1][2] This commit overrides that transparency-detection logic to force the image slice actors to be treated as opaque. Fixes http:https://www.na-mic.org/Bug/view.php?id=4253 [1] https://github.com/Kitware/VTK/blob/bace0bcf81dd6e8d334b78add2d77da37d71398f/Rendering/Core/vtkActor.cxx#L131-L133 [2] https://github.com/Kitware/VTK/blob/bace0bcf81dd6e8d334b78add2d77da37d71398f/Rendering/OpenGL2/vtkOpenGLActor.cxx#L59
jcfr
approved these changes
Sep 24, 2016
|
Integrated in r25394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes rendering of image slices in the 3D view with the VTK
OpenGL2 backend.
The OpenGL2 backend performs more thorough checks than the old backend
when determining whether to treat an actor as opaque or translucent.
Now, in certain cases, VTK determines that the slice texture contains
transparent elements and therefore should treat the actor as
translucent, i.e. rendered without writing to the depth buffer. [1][2]
This commit overrides that transparency-detection logic to force the
image slice actors to be treated as opaque.
Fixes http:https://www.na-mic.org/Bug/view.php?id=4253
[1] https://github.com/Kitware/VTK/blob/bace0bcf81dd6e8d334b78add2d77da37d71398f/Rendering/Core/vtkActor.cxx#L131-L133
[2] https://github.com/Kitware/VTK/blob/bace0bcf81dd6e8d334b78add2d77da37d71398f/Rendering/OpenGL2/vtkOpenGLActor.cxx#L59