Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: making the mask image optional (to match documentation) #1332

Closed
wants to merge 2 commits into from

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Feb 21, 2020

The input is required, otherwise the class produces all-zero output.

Side note: this mask has the opposite semantics from usual (a separate issue).

@dzenanz dzenanz requested a review from lassoan February 21, 2020 16:37
@dzenanz dzenanz changed the title DOC: update documentation of mask input in vtkImageGrowCutSegment ENH: making the mask image optional (to match documentation) Mar 5, 2020
@dzenanz
Copy link
Member Author

dzenanz commented Mar 5, 2020

I was planning to make a new PR, but I forgot this PR was coming from my master branch. The force push turns this into a small feature update.

vtkImageGrowCutSegment.cxx(194,1): warning C4267: 'initializing': conversion from 'size_t' to 'const unsigned char', possible loss of data
@dzenanz dzenanz requested a review from lassoan March 5, 2020 21:39
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I'll merge this.

@lassoan
Copy link
Contributor

lassoan commented Mar 5, 2020

Merged.

@lassoan lassoan closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants