Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is the continuation of the work of @lassoan in PR Slicer/Slicer#1252
Python wrapping of VTK classes seems to work. The remaining errors on Windows are:
The first error should not happen, as the precompiler directive of
#if VTK_MAJOR_VERSION >= 9 || (VTK_MAJOR_VERSION >= 8 && VTK_MINOR_VERSION >= 90)
should work (see line in question in generated file here). Maybe the VTK version variables are not propagated to the project. correctly
In the case of the second error, the python wrapping C++ file is quite different. In the current Slicer master, vtkImageGrowCutSegmentPython.cxx does not contain a PyvtkImageGrowCutSegment_vtkImageGrowCutSegment ragular constructor, but a VTK constructor PyvtkImageGrowCutSegment_NewInstance instead. It is possible that the class is not wrapped as a VTK class.