Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix crash when setting circular parents in subject hierarchy #1223

Closed
wants to merge 1 commit into from
Closed

BUG: Fix crash when setting circular parents in subject hierarchy #1223

wants to merge 1 commit into from

Conversation

cpinter
Copy link
Member

@cpinter cpinter commented Oct 2, 2019

@cpinter cpinter requested a review from lassoan October 2, 2019 17:20
@cpinter cpinter force-pushed the fix-sh-circular-parent-crash branch from fe1c271 to c238985 Compare October 2, 2019 17:23
lassoan
lassoan reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, just two minor comments.

Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Show resolved Hide resolved
Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Outdated Show resolved Hide resolved
@cpinter cpinter force-pushed the fix-sh-circular-parent-crash branch from c238985 to e395cc8 Compare October 2, 2019 17:49
@cpinter
Copy link
Member Author

cpinter commented Oct 2, 2019

Integrated in Slicer/Slicer@a7cbe15

@cpinter cpinter closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpinter @lassoan