Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Add missing include in SlicerBlockInstallCMakeProjects.cmake #1218

Conversation

RafaelPalomar
Copy link

When building Slicer with the following configuration:

	```

-DSlicer_SUPERBUILD=OFF
-DBUILD_TESTING=OFF
-DSlicer_BUILD_EXTENSIONMANAGER_SUPPORT=OFF
-DSlicer_BUILD_CLI_SUPPORT=OFF
-DSlicer_BUILD_CLI=OFF
-DCMAKE_CXX_STANDARD=11
-DSlicer_REQUIRED_QT_VERSION=5
-DSlicer_BUILD_DICOM_SUPPORT=OFF
-DSlicer_BUILD_ITKPython=OFF
-DSlicer_BUILD_QTLOADABLEMODULES=OFF
-DSlicer_BUILD_QT_DESIGNER_PLUGINS=OFF
-DSlicer_USE_CTKAPPLAUNCHER=OFF
-DSlicer_USE_PYTHONQT=OFF
-DSlicer_USE_QtTesting=OFF
-DSlicer_USE_SimpleITK=OFF
-DSlicer_VTK_RENDERING_BACKEND=OpenGL2
-DSlicer_VTK_VERSION_MAJOR=8
-DSlicer_INSTALL_DEVELOPMENT=ON
-DCMAKE_INSTALL_RPATH=/usr/lib64/Slicer-4.11:/usr/lib64/ctk-0.1:/usr/lib64/Slicer-4.11/qt-loadable-modules:/usr/lib64/ITK-5.1.0
-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON
-DSlicer_USE_SYSTEM_LibArchive=ON
-DTeem_DIR=/usr/lib64
-DjqPlot_DIR=/usr/share/jqPlot

The following error raises:

 CMake Error at CMake/SlicerBlockInstallCMakeProjects.cmake:48 (slicer_is_loadable_builtin_module_enabled):

Unknown CMake command "slicer_is_loadable_builtin_module_enabled".
Call Stack (most recent call first):
CMake/SlicerCPack.cmake:165 (include)
CMake/LastConfigureStep/CMakeLists.txt:44 (include)

slicer_is_loadable_builtin_module_enabled is located in
CMake/SlicerCheckModuleEnabled.cmake.

When building Slicer with the following configuration:

		-DSlicer_SUPERBUILD=OFF
		-DBUILD_TESTING=OFF
		-DSlicer_BUILD_EXTENSIONMANAGER_SUPPORT=OFF
		-DSlicer_BUILD_CLI_SUPPORT=OFF
		-DSlicer_BUILD_CLI=OFF
		-DCMAKE_CXX_STANDARD=11
		-DSlicer_REQUIRED_QT_VERSION=5
		-DSlicer_BUILD_DICOM_SUPPORT=OFF
		-DSlicer_BUILD_ITKPython=OFF
		-DSlicer_BUILD_QTLOADABLEMODULES=OFF
		-DSlicer_BUILD_QT_DESIGNER_PLUGINS=OFF
		-DSlicer_USE_CTKAPPLAUNCHER=OFF
		-DSlicer_USE_PYTHONQT=OFF
		-DSlicer_USE_QtTesting=OFF
		-DSlicer_USE_SimpleITK=OFF
		-DSlicer_VTK_RENDERING_BACKEND=OpenGL2
		-DSlicer_VTK_VERSION_MAJOR=8
		-DSlicer_INSTALL_DEVELOPMENT=ON
		-DCMAKE_INSTALL_RPATH=/usr/lib64/Slicer-4.11:/usr/lib64/ctk-0.1:/usr/lib64/Slicer-4.11/qt-loadable-modules:/usr/lib64/ITK-5.1.0
		-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON
		-DSlicer_USE_SYSTEM_LibArchive=ON
		-DTeem_DIR=/usr/lib64
		-DjqPlot_DIR=/usr/share/jqPlot

The following error raises:

     CMake Error at CMake/SlicerBlockInstallCMakeProjects.cmake:48 (slicer_is_loadable_builtin_module_enabled):
   Unknown CMake command "slicer_is_loadable_builtin_module_enabled".
 Call Stack (most recent call first):
   CMake/SlicerCPack.cmake:165 (include)
   CMake/LastConfigureStep/CMakeLists.txt:44 (include)

`slicer_is_loadable_builtin_module_enabled` is located in
`CMake/SlicerCheckModuleEnabled.cmake`.
@pieper
Copy link
Member

pieper commented Oct 1, 2019

Also sounds like a good fix. @jcfr ?

Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

I am integrating now

@jcfr
Copy link
Member

jcfr commented Oct 1, 2019

Closing. Fix integrated in r28528

@jcfr jcfr closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants