Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Subject hierarchy speed up with batch processing #1216

Closed
wants to merge 1 commit into from
Closed

ENH: Subject hierarchy speed up with batch processing #1216

wants to merge 1 commit into from

Conversation

cpinter
Copy link
Member

@cpinter cpinter commented Sep 30, 2019

No description provided.

@cpinter
Copy link
Member Author

cpinter commented Sep 30, 2019

I'll integrate this tomorrow so that we have a preview version with Slicer/Slicer#1215 and without this change. If there are any issues let me know.

@cpinter cpinter force-pushed the sh-speedup-with-batch-processing branch from 64e3d20 to 9ea2e20 Compare October 1, 2019 19:59
@cpinter
Copy link
Member Author

cpinter commented Oct 1, 2019

I found some issues, made some fixes, and it looks like this:
https://1drv.ms/v/s!Ao_a-dPPX98Zg4cyTpIHAN-GHEUolg?e=6OgxgD
@jcfr @pieper @fedorov @rkikinis Check out the video, I think you'll find it cool.

The main problem as always was after scene closing, that's why I included it in the video.

After show/hiding a big branch there some flickering and reseting of the layout spacer. Not sure why it happens, maybe something happens with the scene views after batch processing ends? @lassoan
Otherwise (and even including this flickering :) ) it looks great to me. If there are no comments I'll integrate this tomorrow.

@jcfr
Copy link
Member

jcfr commented Oct 1, 2019

I found some issues, made some fixes, and it looks like this:
https://1drv.ms/v/s!Ao_a-dPPX98Zg4cyTpIHAN-GHEUolg?e=6OgxgD
Check out the video, I think you'll find it cool.

Well done 🙏

And it is quite fast to toggle entire sub-hierarchy

@cpinter cpinter force-pushed the sh-speedup-with-batch-processing branch from 9ea2e20 to e417fbc Compare October 2, 2019 02:31
@cpinter cpinter changed the title BUG: Batch processing now works correctly with subject hierarchy ENH: Subject hierarchy speed up with batch processing Oct 2, 2019
@cpinter cpinter force-pushed the sh-speedup-with-batch-processing branch from e417fbc to 0d4fb19 Compare October 2, 2019 02:43
@cpinter
Copy link
Member Author

cpinter commented Oct 2, 2019

Integrated in Slicer/Slicer@e264333

@cpinter cpinter closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@cpinter @jcfr