Update to itk5 #1179
Update to itk5 #1179
Conversation
"Scenes" are now "Groups" with "Children" instead of "Objects" https://discourse.itk.org/t/build-error-with-itk5-spatialobjects-scene/2062
Use ValueAtInWorldSpace to replace ValueAt per suggestion from Stephen Aylward. https://discourse.itk.org/t/build-error-with-itk5-spatialobjects-scene/2062/7
This fixes a build error when using ITKv5. Suggestion from Hans Johnson is not to build DemonWarp since it is no longer used (the suggestion is to use ANTS instead). BRAINSia/BRAINSTools#449
Since we are current with the v5 versions of both repositories we do not need to use separate forks in the Slicer organization (these can be left around in case they are needed in the future).
|
There is one patch. See https://github.com/Slicer/ITK/commits/slicer-v5.0.rc01-2019-01-30-eb54c22 |
|
Quite a few extensions are broken when building against ITKv5 release (my linux build is marked "(empty)", but many breakages are also present in the current SlicerPreview built against Slicer/ITK and the errors appear very similar, at least at a glance but there are definitely a few issues related to SpatialObjects and other issues that changed between the rc and the release. http:https://slicer.cdash.org/index.php?project=SlicerPreview&date=2019-08-05 I think it will be easier to encourage extension developers to fix their builds against the ITK release rather than the release candidate. So I suggest we merge this pull request. @jcfr is the one commit you added to Slicer/ITK likely to be merged into an ITK release? If yes I suggest we switch to that release and use the upstream repo. If no then I suggest we update Slicer/ITK to v5 release and re-add our patch on top. |
|
Slicer/ITK@4f7f4bf is not likely to be integrated into ITK. Why do you want it to be able to build as an external module? @jcfr Why not just enable it for building when initially configuring ITK? |
|
Closing. Integrated in r28440 |
@jcfr for this I referenced upstream repos and not our Slicer org forks. Were there any patches still outstanding that aren't in the upstream? If you agree, I think we should change the Welcome branches of to say that they are for legacy use (e.g. for 4.10) but won't be used in the future unless specific needs arise.
p.s. there's no particular rush, but this extension needs a fix from itk5 to build on mac.