ENH: Handle 3D events in MRML interactor style and markups VTK widget… #1142
Conversation
cpinter
force-pushed
the
markups-3d-event-handling
branch
from
f6524dd
to
4bfcfc6
Compare
|
I think this should be good to go as a first step. @lassoan what do you think? |
Libs/MRML/DisplayableManager/vtkMRMLThreeDViewInteractorStyle.h
Outdated
Show resolved
Hide resolved
| { | ||
| public: | ||
| static vtkMRMLViewInteractorStyle *New(); | ||
| vtkTypeMacro(vtkMRMLViewInteractorStyle,vtkInteractorStyleUser); | ||
| vtkTypeMacro(vtkMRMLViewInteractorStyle,vtkInteractorStyle3D); |
There was a problem hiding this comment.
why was it necessary to switch to vtkInteractorStyle3D?
There was a problem hiding this comment.
This may not have been necessary. Now that I checked again, the OnMove3D and OnButton3D functions are available in vtkInteractorStyle, which is the subclass of vtkInteractorStyleUser (I think this is what I missed). Do you want me to change back?
There was a problem hiding this comment.
It is better to use as simple base class as possible, so if vtkInteractorStyle3D is not needed then change back to the old one.
There was a problem hiding this comment.
I know know... It was a subclass of the 3D interactor so that vtkVirtualRealityViewInteractorStyle can call Dolly3D and other functions that it needs. I'll revert OK?
There was a problem hiding this comment.
Such methods are moved to the camera widget. Handling such events n the he widget allows remapping of GUI events to various interactions and a more stable routing of events (e.g., the effect of a gesture may depend in what widget currently has the focus and what state it is in).
For short term you can choose any option, but in the mid/long term we are moving away from one centralized interactor style + some widgets and instead we will handle all interactions in widgets.
If the new model works well then we'll work on pushing it into VTK, thereby reducing redundancy.
Modules/Loadable/Markups/VTKWidgets/vtkSlicerMarkupsWidgetRepresentation3D.cxx
Show resolved
Hide resolved
Modules/Loadable/Markups/VTKWidgets/vtkSlicerMarkupsWidgetRepresentation3D.cxx
Outdated
Show resolved
Hide resolved
cpinter
force-pushed
the
markups-3d-event-handling
branch
from
4bfcfc6
to
5799603
Compare
|
Thanks for the review! It's integrated in Slicer/Slicer@3cec087 I'll continue with mapping states to interaction contexts and then handling further events (button press) |
…s