Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support for removing entries from modules menu #1133

Closed

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Apr 25, 2019

This commit adds the function "removeCategory()" and update the signature
of "removeModule()" to accept removeFromAllModules argument.

This is particularly useful in the context of Slicer custom application.
Indeed, it allows to unclutter the list of modules and category presented
in the module selector while keeping them available in the "All Modules"
general listing for direct selection or search.

Todo:

  • add test

@jcfr jcfr requested a review from lassoan April 25, 2019 21:09
jcfr referenced this pull request in slicersalt/Slicer Apr 25, 2019
…rom modules menu

This commit adds the function "removeCategory()" and update the signature
of "removeModule()" to accept removeFromAllModules argument.

This is particularly useful in the context of Slicer custom application.
Indeed, it allows to unclutter the list of modules and category presented
in the module selector while keeping them available in the "All Modules"
general listing for direct selection or search.
jcfr referenced this pull request in Kitware/SlicerSALT Apr 25, 2019
List of changes:

$ git shortlog 1589b3d51..4a520af04 --no-merges
Jean-Christophe Fillion-Robin (1):
      [Backport Slicer/Slicer#1133] ENH: Add support for removing entries from modules menu

jcfr (1):
      [Backport] ENH: Allow moduleAction and modulesMenu functions to be accessible from python
jcfr referenced this pull request in slicersalt/Slicer Apr 25, 2019
jcfr referenced this pull request in Kitware/SlicerSALT Apr 25, 2019
List of changes:

$ git shortlog 4a520af04..ab6305d89 --no-merges
Jean-Christophe Fillion-Robin (1):
      [Backport Slicer/Slicer#1133] BUG: Fix qSlicerModulesMenu.removeCategory()
jcfr and others added 4 commits April 26, 2019 01:40
…ation

The file is expected to be in the top-level binary directory.

git-svn-id: https://svn.slicer.org/Slicer4/trunk@28177 3bd1e089-480b-0410-8dfb-8563597acbee
This commit adds the function "removeCategory()" and update the signature
of "removeModule()" to accept removeFromAllModules argument.

This is particularly useful in the context of Slicer custom application.
Indeed, it allows to unclutter the list of modules and category presented
in the module selector while keeping them available in the "All Modules"
general listing for direct selection or search.
@jcfr jcfr force-pushed the support-category-removal-modules-menu branch from 0499ed9 to 6c55bd8 Compare April 26, 2019 01:40
jcfr referenced this pull request in slicersalt/Slicer Apr 26, 2019
…rom modules menu

This commit adds the function "removeCategory()" and update the signature
of "removeModule()" to accept removeFromAllModules argument.

This is particularly useful in the context of Slicer custom application.
Indeed, it allows to unclutter the list of modules and category presented
in the module selector while keeping them available in the "All Modules"
general listing for direct selection or search.
jcfr referenced this pull request in slicersalt/Slicer Apr 26, 2019
jcfr referenced this pull request in Kitware/SlicerSALT Apr 26, 2019
$ git shortlog 85f47844..218e8ebd1 --no-merges
Jean-Christophe Fillion-Robin (2):
      [Backport Slicer/Slicer#1133] ENH: Add support for removing entries from modules menu
      [Backport Slicer/Slicer#1133] BUG: Fix qSlicerModulesMenu.removeCategory()

jcfr (10):
      ENH: Allow moduleAction and modulesMenu functions to be accessible from python
      COMP: Fix configuration of CTestCustom.cmake for Slicer custom application
      STYLE: Fix DOCUMENTATION_ARCHIVES_OUTPUT_DIRECTORY default value for custom app
      ENH: Update VTK to include support for shader replacement
      COMP: Set Slicer_BUILD_WEBENGINE_SUPPORT to ON by default
      BUG: Fix vtkMRMLCameraDisplayableManagerTest1 baseline scene
      BUG: Fix c++ tests involving layout when Slicer_BUILD_WEBENGINE_SUPPORT is OFF
      COMP: Fix qSlicerExtensionsManagerWidget build error
      COMP: Fix -Wunused-variable warnings in qSlicerSubjectHierarchySegmentationsPlugin
      ENH: qSlicerWebWidget: Remove debug statement

lassoan (1):
      BUG: Fix DICOM listener starting and stopping on Windows

pieper (2):
      ENH: add debug for python evaluation from webengine
      BUG: fix dicom listener process check for python3
@jcfr
Copy link
Member Author

jcfr commented May 2, 2019

Closing. Superseded by Slicer/Slicer#1134

@jcfr jcfr closed this May 2, 2019
@jcfr jcfr deleted the support-category-removal-modules-menu branch May 2, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant