ENH: Added option to load MRB files from Sample Data module #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
approved these changes
Dec 19, 2018
|
Thanks @smrolfe 👍 The change makes sense. |
|
I will integrate the change and also update the docstring. |
|
Great! thanks @jcfr |
|
Closing. Fix integrated in r27666 |
sjh26
pushed a commit
to slicersalt/Slicer
that referenced
this pull request
Oct 4, 2024
Updated CTK to include a couple of small fixes and improvements. Revision: ef3d86b3b9053f4fa53e8e4a6ab9ab42db14f88b Author: Andras Lasso <[email protected]> Date: 2023-03-09 2:03:48 PM Message: BUG: Ensure that the min/max values can be reached in ctkDoubleSlider and ctkDoubleRangeSlider The minimum and maximum values were not always reachable in ctkDoubleSlider and ctkDoubleRangeSlider widgets when moved the slider to the minimum or maximum position. For example: ``` lo = -1024 hi = 2000 step = (hi - lo) / 1000. thresholdSlider = ctk.ctkRangeWidget() thresholdSlider.spinBoxAlignment = qt.Qt.AlignTop thresholdSlider.setRange(lo, hi) thresholdSlider.singleStep = step thresholdSlider.show() # Impossible to reach 2000.0 slider = ctk.ctkDoubleSlider() slider.minimum = lo slider.maximum = hi slider.singleStep = step slider.show() slider.connect("valueChanged(double)", lambda v: print(v)) # Impossible to reach 2000.0 ``` The problem was that the integer slider range was determined by rounding, which could result in the integer slider range not covering the entire value range. Fixed the problem by extending the integer slider range when it did not fully cover the value range. Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]> Revision: 681e208dadf6c89cbd7b3ef44a1a40dc726d1993 Author: Andras Lasso <[email protected]> Date: 2023-03-10 2:15:14 PM Message: DOC: Improve ctkSettingsDialog API documentation Added a single clarification comment. Revision: 30237e9ffefd3d5e879ab61ef072d9b267c4fc82 Author: Mouhamed DIOP <[email protected]> Date: 2023-03-01 2:25:32 PM Message: BUG: Fix lupdate warnings on translation function calls Qt lupdate tool throws `Cannot invoke tr() like this` warnings when translation function is called using `q->tr(...)`. The problem is that lupdate cannot determine the class name `tr()` is called on and therefore it does not know the translation context. The solution is to spell out the class name in the call, for example `ctkSettingsDialog::tr(...)`. More details are described here: https://github.com/Slicer/SlicerLanguagePacks/blob/main/DevelopersManual.md see Slicer/SlicerLanguagePacks#17 see Slicer/SlicerLanguagePacks#12 Revision: 3286ac34e5aca30918843bdabd004477d577f03e Author: Steve Pieper <[email protected]> Date: 2023-02-22 11:03:34 AM Message: ENH: Follow symlinks in dicom indexing (Slicer#1066) Enabled by default, but settable as a property. Fixes Slicer#1065 Revision: 2daac1c6f3831d36acd8079f33000f0c9f4737ad Author: Andras Lasso <[email protected]> Date: 2023-01-20 1:21:06 AM Message: BUG: Fixed restoring of DICOM metadata viewer window size After the DICOM metadata viewer window was show maximized and then closed by hitting Escape button: the metadata viewer opened the widget maximized, but the layout inside was much smaller. Applied parts of [this workaround](https://stackoverflow.com/questions/44005852/qdockwidgetrestoregeometry-not-working-correctly-when-qmainwindow-is-maximized) to ensure that the widget size is restored when the window is maximized. Revision: 84a2f672ead98bb962eaf8f2c8ac17754712d9e4 Author: Andras Lasso <[email protected]> Date: 2023-01-20 1:17:39 AM Message: BUG: Fix initial state of ctkExpandButton The initial direction of the double-arrow button was incorrect (left-to-right instead of right-to-left), as the icon was only updated when the user clicked on it, and not when the checked state was changed by calling `setChecked()`. Revision: 47216921393dc8a5e85974288e036d6953c15cb5 Author: Steve Pieper <[email protected]> Date: 2021-06-28 8:33:11 PM Message: ENH: Display thumbnail in DICOM metadata To allow a way to reduce "time to first image" in the DICOM browser and help testing troubleshooting, an image thumbnail is displayed in the DICOM metadata browser window. The thumbnail is only retrieved if the collapsible section is open (to save space and improve performance when accessing large images). Based on ProjectWeek discussion: https://projectweek.na-mic.org/PW35_2021_Virtual/Projects/mpReview/ Co-authored-by: Andras Lasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Sample Data module, scene files (.mrb or .mrml) are not loaded into Slicer by default. This default could not be changed when registering a custom data set. Now a parameter has been added to specify if the files should be loaded for a custom data set.