ENH: Allow observing color name change #1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
@vovythevov Do you foresee any issue with this change ? |
slicerbot
referenced
this pull request
Nov 8, 2018
Integrates Slicer/Slicer#1037 git-svn-id: https://svn.slicer.org/Slicer4/trunk@27537 3bd1e089-480b-0410-8dfb-8563597acbee
|
Integrated in Slicer/Slicer@94fb4a6 |
jcfr
referenced
this pull request
Jan 16, 2019
Integrates Slicer/Slicer#1037 git-svn-id: https://svn.slicer.org/Slicer4/branches/Slicer-4-10@27750 3bd1e089-480b-0410-8dfb-8563597acbee
jcfr
added a commit
to Slicer/Slicer
that referenced
this pull request
Mar 13, 2020
Integrates Slicer/SlicerGitSVNArchive#1037 svn-url: https://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=27750 git-svn-id: https://svn.slicer.org/Slicer4/branches/Slicer-4-10@27750 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to update the scalar bar when the isodose level is changed. Isodose level is stored as the color name, and it can be changed in a color table view. Related issue: SlicerRt/SlicerRT#8
I'm issueing a PR because there was a TBD there but also because I'm not sure what are the cases where color names might be changed in bulk, causing potential issues with lots of Modified events.