BUG: Fix 3D picking in displayable managers #1032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Oct 22, 2018
jcfr
reviewed
Oct 22, 2018
Model and segmentation displayable managers use vtkCellPicker to pick a node in a certain RAS position. The current implementation uses the GetDataSet method to get the first picked dataset. However, that dataset might be one that is not managed by the caller DM. This is fixed by going through all the picked props and finding the first managed prop.
cpinter
force-pushed
the
fix-displayable-manager-3dpick
branch
from
7a3ca0c
to
06629c9
Compare
|
Integrated in Slicer/Slicer@65550bc |
jcfr
referenced
this pull request
in slicersalt/Slicer
Apr 24, 2019
…NGINE_SUPPORT option This new option allows to build custom Slicer applications without WebEngine libraries and without the qSlicerWebWidget, qSlicerWebDownloadWidget and qSlicerWebPythonProxy classes. It reduces the install size by ~120MB
jcfr
referenced
this pull request
in slicersalt/Slicer
Apr 24, 2019
…NGINE_SUPPORT option This new option allows to build custom Slicer applications without WebEngine libraries and without the qSlicerWebWidget, qSlicerWebDownloadWidget and qSlicerWebPythonProxy classes. It reduces the install size by ~120MB
jcfr
referenced
this pull request
in slicersalt/Slicer
Apr 24, 2019
…NGINE_SUPPORT option This new option allows to build custom Slicer applications without WebEngine libraries and without the qSlicerWebWidget, qSlicerWebDownloadWidget and qSlicerWebPythonProxy classes. It reduces the install size by ~120MB
jcfr
referenced
this pull request
in slicersalt/Slicer
Apr 25, 2019
…NGINE_SUPPORT option
This new option allows to build custom Slicer applications without
WebEngine libraries. It reduces the install size by ~120MB
If Slicer_BUILD_WEBENGINE_SUPPORT option is OFF, the following happens:
- exclude the following classes:
- qSlicerWebWidget, qSlicerWebDownloadWidget and qSlicerWebPythonProxy
- qMRMLExpandingWebView and qMRMLExpandingWebViewPlugin
- qMRMLChartView, qMRMLChartWidget and qMRMLChartViewControllerWidget
- views:
- skip registration of qMRMLLayoutChartViewFactory in layout manager
and return sensible values for method like viewNode(), viewWidget()
- skip download of jqPlot only used in qMRMLChartView class
- vtkMRMLChart nodes are still available and registered.
- disable tab showing shortcuts in qSlicerActionsDialog
- datastore module is not available
- extension manager:
- enabling Slicer_BUILD_EXTENSIONMANAGER_SUPPORT while having
Slicer_BUILD_WEBENGINE_SUPPORT off is supported.
- installing from file is still supported.
- in "Manage Extensons" tab, clicking on an extension link will NOT
show a web-browser inside the manager.
- in "Install Extensions" tab, nothing will be shown.
This commit also enables sharing of GL context. This is required when
the application is build with optionSlicer_BUILD_WEBENGINE_SUPPORT set
to OFF and the designer plugin "qwebengineview" is attempted to be loaded.
It addressed the following warning reported during application startup:
Qt WebEngine seems to be initialized from a plugin. Please set Qt::AA_ShareOpenGLContexts using QCoreApplication::setAttribute before constructing QGuiApplication.
loaded library "/path/to/Qt5.10.0/5.10.0/gcc_64/plugins/designer/libqwebengineview.so"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model and segmentation displayable managers use vtkCellPicker to pick a node in a certain RAS position. The current implementation uses the GetDataSet method to get the first picked dataset. However, that dataset might be one that is not managed by the caller DM. This is fixed by going through all the picked props and finding the first managed prop.