Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs-modified #20

Merged
merged 1 commit into from
Nov 4, 2022
Merged

libs-modified #20

merged 1 commit into from
Nov 4, 2022

Conversation

1yiyezhiqiu
Copy link
Collaborator

markdown for OmgPianoTranscription/libpianotranscription/src/main/java/libpianotranscription/midi/MidiWriter.java

@SleepyLGod SleepyLGod self-requested a review November 4, 2022 13:08
SleepyLGod
SleepyLGod reviewed Nov 4, 2022
View reviewed changes
Copy link
Owner

@SleepyLGod SleepyLGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thx!

@SleepyLGod SleepyLGod added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Nov 4, 2022
@SleepyLGod SleepyLGod linked an issue Nov 4, 2022 that may be closed by this pull request
enhancement: convert the mp3 files to midi files and play them dynamically #4
Open
11 tasks
@SleepyLGod SleepyLGod merged commit b8e1c6f into dev-midi-generator Nov 4, 2022
SleepyLGod
SleepyLGod reviewed Nov 4, 2022
View reviewed changes
Copy link
Owner

@SleepyLGod SleepyLGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, you could add some more annotations with a standard format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepyLGod SleepyLGod SleepyLGod left review comments

Assignees

@1870944317 1870944317

@SleepyLGod SleepyLGod

@1yiyezhiqiu 1yiyezhiqiu

@zzhisthebest zzhisthebest

Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: convert the mp3 files to midi files and play them dynamically
4 participants
@1yiyezhiqiu @SleepyLGod @1870944317 @zzhisthebest