Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix midi generator cli #17

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Fix midi generator cli #17

merged 4 commits into from
Nov 10, 2022

Conversation

SleepyLGod
Copy link
Owner

@SleepyLGod SleepyLGod commented Nov 2, 2022 •
edited
Loading

🔨 Generator fix (#11 Modification)

@SleepyLGod

  • Bugs of the logic of interfaces fixed.
    • Bug fixed: local files' transition.
    • Bug fixed: return the related midi files in the response.
      • Return format passed.
      • Test passed.
  • HTTP request demos added.

@SleepyLGod SleepyLGod added bug Something isn't working question Further information is requested java Pull requests that update Java code labels Nov 2, 2022
@SleepyLGod SleepyLGod linked an issue Nov 2, 2022 that may be closed by this pull request
enhancement: convert the mp3 files to midi files and play them dynamically #4
Open
11 tasks
@SleepyLGod SleepyLGod mentioned this pull request Nov 3, 2022
Open
11 tasks
@SleepyLGod
Copy link
Owner Author

Initially fixed!🎉

@SleepyLGod SleepyLGod merged commit 7653e07 into dev-midi-generator Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@1870944317 1870944317

@SleepyLGod SleepyLGod

@1yiyezhiqiu 1yiyezhiqiu

@zzhisthebest zzhisthebest

Labels
bug Something isn't working java Pull requests that update Java code question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: convert the mp3 files to midi files and play them dynamically
4 participants
@SleepyLGod @1870944317 @1yiyezhiqiu @zzhisthebest