Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make all Dungeon solver colors customizable #487

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Coccocoahelper
Copy link

Not ready yet, but likely not going to break things. Try it once it compiles.

Not ready, but likely not going to break thing

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <[email protected]>
@Coccocoahelper Coccocoahelper marked this pull request as ready for review June 26, 2024 09:04
Copy link
Member

@Sychic Sychic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config
e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

@Coccocoahelper
Copy link
Author

e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

My bad, fixing it.

@Coccocoahelper
Copy link
Author

e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config e: file:https:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

Can you make it try to compile rn?

@@ -35,7 +35,7 @@ fun setChestColor(
ci: CallbackInfo
) {
if (te.pos == ThreeWeirdosSolver.riddleChest) {
ticTacToeSolverColor.bindColor()
Skytils.config.threeWeirdosSolverColor.bindColor()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just import the static and not the surrounding class.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to try that out, thank you for the advice! Also, are Kotlin mixins viable for other… mods?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just import the static and not the surrounding class.

That doesn't appear possible. I'll revert it to the old method

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants