[pull] master from istio:master #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Enhancements to proxy-status * add note
* manifests: fix gateways.securityContext not work Signed-off-by: Tianpeng Wang <[email protected]> * make gen --------- Signed-off-by: Tianpeng Wang <[email protected]>
Signed-off-by: spacewander <[email protected]>
* Fix sidecar DNS proxying with dual stack Fixes #51608 * Add test
Signed-off-by: xin.li <[email protected]>
* Don't reset the jwks refresh ticker on URI fetch errors When there is an error fetching a JWKS URI in the main flow (i.e. when generating configuration), an immediate background refresh is triggered. However this is only a partial refresh and will only fetch URIs that don't have an entry in the cache, i.e. the URIs that had errors, in the hope that the requests will succeed and the keys can be sent to the affected proxies. When this partial refresh was triggered, the background refresh ticker was being reset. So there would be a longer delay before any URIs already in the cache would be fetched again to see if there are any changes. The default interval between refreshes is 20 minutes, and there is exponential backoff on failure up to 60 minutes, so in the case of a busy istiod, and a single invalid URI, there may never be an interval that doesn't trigger this partial refresh. In this case the cached entries never end up getting updated. This change makes it so that the partial refresh triggered on an error does not reset the ticker used for the full background refresh. * Add release notes * Log instead of fail in goroutine (found by lint) * Fix data race by using different variable in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )