Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom HTTP request in dstore/Request. #206

Merged
merged 1 commit into from
May 26, 2017

Conversation

mwistrand
Copy link
Member

Allow users to provide a custom request promise for loading data via dstore/Request in a manner that does not require duplicating common functionality from dstore/Request#_request.

Resolves #68

Allow users to provide a custom `request` promise for loading data via
`dstore/Request` in a manner that does not require duplicating common
functionality from `dstore/Request#_request`.
Copy link

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@dylans dylans added this to the 1.2 milestone May 24, 2017
@mwistrand mwistrand merged commit 655a36c into SitePen:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants