QueryResults.forEach callback parameters not as expected

[markaedwards]

Hi
Just a little thing, just started using the latest release which has introduced QueryResults. The forEach function calls the provided callback with the parameters -
data[i], data
whereas the normally expected signature for a forEach callback would have the index as the second parameter i.e. -
data[i], i, data

Loving the whole dstore thing, nice work!

Regards

Mark

[kriszyp]

Yes, I agree, will try to get that fixed soon.

[kriszyp]

Sorry about the comment in the wrong ticket (will still try to get this fixed soon).

[kriszyp]

Looks like this was fixed with 8d5146a

[csnover]

The commit in the previous comment fixes only Store#forEach, not QueryResults#forEach. The latter API is still broken until 9afdf9e and there hasn’t been a new release since then with the fix.