Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching-store exception propagation #213

Closed
gerpres opened this issue Nov 7, 2017 · 0 comments
Closed

Caching-store exception propagation #213

gerpres opened this issue Nov 7, 2017 · 0 comments
Labels
bug
Milestone
1.1.3

Comments

@gerpres
Copy link
Contributor

gerpres commented Nov 7, 2017

if a e.g. RequestMemory.add/.put fails on the server side, the returned promise is not rejected.
furthermore Cache.put contains invalid references in the exception-case.

this.getIdentity

is not valid in this context.
environment: latest dgrid,dstore, dojo 1.13
gerpres added a commit to gerpres/dstore that referenced this issue Nov 7, 2017
@gerpres
fix multiple findings regarding serverside-rejection/exceptions
1219488 
propagate exception to promise. use correct reference for local store.
fixes SitePen#213
@gerpres gerpres mentioned this issue Nov 7, 2017
Closed
@dylans dylans added this to the 1.1.3 milestone Dec 2, 2017
@dylans dylans added the bug label Dec 2, 2017
@edhager edhager closed this as completed in eaff671 May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.3
Development

Successfully merging a pull request may close this issue.

fix multiple findings regarding serverside-rejection/exceptions gerpres/dstore
2 participants
@dylans @gerpres